Reorganize trotter and apply_gate code#338
Open
Yue-Zhengyuan wants to merge 2 commits intoQuantumKitHub:masterfrom
Open
Reorganize trotter and apply_gate code#338Yue-Zhengyuan wants to merge 2 commits intoQuantumKitHub:masterfrom
Yue-Zhengyuan wants to merge 2 commits intoQuantumKitHub:masterfrom
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
kshyatt
reviewed
Feb 27, 2026
kshyatt
reviewed
Feb 27, 2026
| @@ -0,0 +1,395 @@ | |||
| #= | |||
Member
There was a problem hiding this comment.
What on earth is happening with this docstring, haha, why is it commented out?
Member
Author
There was a problem hiding this comment.
I wrote this mostly as a personal pedagogic note on how the (crude) truncation in an MPO is done and didn't intend to make it appear in the docstring. Anyway, it can be used as the docstring of _cluster_truncate!, but I feel it is too long and over-detailed for the purpose. 😅
kshyatt
reviewed
Feb 27, 2026
Member
|
Looks great! Left some small nits to improve things while they are being touched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes simple update code in order to get ready for the addition of the feature to decompose next-nearest-neighbor (NNN) gates into nearest-neighbor (NN) gates (briefly described here), without turning
evoltools.jlinto a big mess. The ultimate goal is to reuse the NN code of Trotter time evolution for NNN Hamiltonians.As this PR does not change any code logic, it can be safely merged once the tests pass.