Define + for LocalOperators

[Gertian]

I defined addition for Localoperators

[lkdvos]

Maybe in the meantime it might be convenient to also add -, and scalar multiplication?

[Gertian]

Maybe in the meantime it might be convenient to also add -, and scalar multiplication?

Sure, I didn't need those so I didn't think of it.
I'll get to it in the near future.

[Gertian]

It might be useful to also check when H1 - H2 contains operators that are 0 that can therefore be thrown away.
The issue is that this requires some sort of tolerance which is a bit ambiguous.

Any suggestions/preferences ? Or do we just ignore this subtlety ?

[lkdvos]

Honestly, maybe we just add a default tolerance for that? something like norm < eps^(3/4) (1e-12) sounds reasonable to me.
I think the cleaner approach is then to just ignore this in the + methods, and just handle this in the constructor (where we can have the tolerance as a kwarg).

[Gertian]

Okay. I'll implement it like that.

[lkdvos]

I made some slight changes and added a very basic docstring, thanks for getting this started!
Once the tests turn green, I think this is good to go from my side.

[Gertian]

I made some slight changes and added a very basic docstring, thanks for getting this started! Once the tests turn green, I think this is good to go from my side.

This all looks great for me. And you're welcome ! :)

[codecov]

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Files	Patch %	Lines
src/operators/localoperator.jl	61.76%	13 Missing ⚠️

Files	Coverage Δ
src/operators/localoperator.jl	74.57% <61.76%> (-19.71%)	⬇️

[pbrehmer]

Also looks great to me, thanks for that! :-)