Conversation
Codecov ReportAttention: Patch coverage is
|
Member
Author
|
From the codecov it also seems like we are not testing any ctmrg run with changing spaces, so this might also be something to look into. |
Collaborator
|
Thanks for the clean up, that's definitely an improvement! Previously (as you hint at in the code comment), changing spaces during a CTMRG run would error due differences between tensors on different spaces. But now this should possible. Maybe I will take a look after I'm back from vacation and come up with a simple test for varying spaces (maybe increasing the environment dimensions during the run or something like that...). |
pbrehmer
approved these changes
Aug 29, 2024
Member
Author
|
Definitely enjoy the holiday first ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should provide a slightly more robust error computation, which will no longer output
Infwhen the spaces are still changing. The only downside is that it might say that something is converged while it is not, because it only checks the difference on the overlap of the changing spaces.In principle, we could still remedy this, but I would be okay with just having this as is and seeing if it ever shows up as an issue.