Skip to content

Improve CTMRG error computation#65

Merged
lkdvos merged 2 commits intomasterfrom
ld-errorcomputation
Aug 29, 2024
Merged

Improve CTMRG error computation#65
lkdvos merged 2 commits intomasterfrom
ld-errorcomputation

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Aug 28, 2024

This should provide a slightly more robust error computation, which will no longer output Inf when the spaces are still changing. The only downside is that it might say that something is converged while it is not, because it only checks the difference on the overlap of the changing spaces.
In principle, we could still remedy this, but I would be okay with just having this as is and seeing if it ever shows up as an issue.

@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/ctmrg/gaugefix.jl 63.63% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/ctmrg/gaugefix.jl 94.73% <63.63%> (-3.47%) ⬇️

@lkdvos lkdvos requested a review from pbrehmer August 28, 2024 10:05
@lkdvos
Copy link
Member Author

lkdvos commented Aug 28, 2024

From the codecov it also seems like we are not testing any ctmrg run with changing spaces, so this might also be something to look into.

@pbrehmer
Copy link
Collaborator

Thanks for the clean up, that's definitely an improvement! Previously (as you hint at in the code comment), changing spaces during a CTMRG run would error due differences between tensors on different spaces. But now this should possible. Maybe I will take a look after I'm back from vacation and come up with a simple test for varying spaces (maybe increasing the environment dimensions during the run or something like that...).

@lkdvos lkdvos merged commit ab0d215 into master Aug 29, 2024
@lkdvos lkdvos deleted the ld-errorcomputation branch August 29, 2024 17:21
@lkdvos
Copy link
Member Author

lkdvos commented Aug 29, 2024

Definitely enjoy the holiday first ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants