Skip to content

Fix CTMRG miniter and Accessors.@set#74

Merged
pbrehmer merged 2 commits intomasterfrom
pb-fix-miniter
Oct 9, 2024
Merged

Fix CTMRG miniter and Accessors.@set#74
pbrehmer merged 2 commits intomasterfrom
pb-fix-miniter

Conversation

@pbrehmer
Copy link
Collaborator

@pbrehmer pbrehmer commented Oct 9, 2024

This small PR will fix two small things:

  1. The miniter condition didn't work anymore in leading_boundary runs
  2. Using the @set macro from Accessors.jl for the CTMRG struct wouldn't work due to the type parameter

@pbrehmer pbrehmer requested a review from lkdvos October 9, 2024 09:57
@pbrehmer pbrehmer merged commit 1d84977 into master Oct 9, 2024
@pbrehmer pbrehmer deleted the pb-fix-miniter branch October 9, 2024 10:20
@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/ctmrg/ctmrg.jl 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/ctmrg/ctmrg.jl 94.27% <50.00%> (-0.50%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants