Change default SVD algorithm to SDD and update tests#83
Merged
Conversation
Codecov ReportAttention: Patch coverage is
|
lkdvos
approved these changes
Oct 31, 2024
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I really like that we are using more Defaults in the tests and reduce the kwargs, looks great for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will change the default SVD algorithm to
TensorKit.SDDsince this generally outperformsTensorKit.SVDand is used as the default algorithm in TensorKit (and Base usesgesdd). Since this anyways modifies many tests, I will update the tests such that they all use the updatedDefaultsto the fullest possible extent.