Added link to Qubes Mailing Lists#158
Added link to Qubes Mailing Lists#158andrewdavidwong merged 3 commits intomasterfrom unknown repository
Conversation
_data/teamtexts.yml
Outdated
| title: Community Contributors | ||
| text: Qubes would not be where it is today without the input of the many users, testers, and developers of all skill levels who have come together to form this thriving community. The community's discussions take place primarily on the | ||
| mail: Qubes mailing lists | ||
| text: Qubes would not be where it is today without the input of the many users, testers, and developers of all skill levels who have come together to form this thriving community. The community's discussions take place primarily on the <a href="/support/">Qubes mailing lists and forum</a> |
There was a problem hiding this comment.
This is definitely not the intended way to fix this.
I doubt there's supposed to be HTML in this text snippet. If you look here, you can see the problematic line:
qubesos.github.io/_includes/team.html
Line 173 in 160ef08
The problem is that I can't find support_link anywhere else. Looks like this was introduced in #153. @maiska, what did you have in mind here?
There was a problem hiding this comment.
You're right, there is probably a better way. This method works (it renders correctly), I don't know enough about jekyll to know how to do it.
There was a problem hiding this comment.
Hello, sorry for my long silence, I should be more flexible from now on. This here is clearly a mistake, sorry for that, this should be declared a variable which slipped the commit if I am not mistaken in the history of the file, such as {% assign team_link = lang | append: "/team/" %}
somthing like that:
{% assign support_link = lang | append: "/support/" %}
There was a problem hiding this comment.
Hello, sorry for my long silence, I should be more flexible from now on. This here is clearly a mistake, sorry for that, this should be declared a variable which slipped the commit if I am not mistaken in the history of the file, such as
{% assign team_link = lang | append: "/team/" %}somthing like that:
{% assign support_link = lang | append: "/support/" %}
@maiska: Take a look at what has already been merged and please submit a new PR if warranted.
There was a problem hiding this comment.
@andrewdavidwong I see you fixed it :) Thank you
|
Slight improvement from before, still could use some improvement. the upperlinks section has all of its text/url pairs inside another layer (security/bug/ect), while community (after this commit) has some in the top level and some nested under mail. |
Fixes QubesOS/qubes-issues#6533