Skip to content

Added link to Qubes Mailing Lists#158

Merged
andrewdavidwong merged 3 commits intomasterfrom
unknown repository
Apr 17, 2021
Merged

Added link to Qubes Mailing Lists#158
andrewdavidwong merged 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 16, 2021

title: Community Contributors
text: Qubes would not be where it is today without the input of the many users, testers, and developers of all skill levels who have come together to form this thriving community. The community's discussions take place primarily on the
mail: Qubes mailing lists
text: Qubes would not be where it is today without the input of the many users, testers, and developers of all skill levels who have come together to form this thriving community. The community's discussions take place primarily on the <a href="/support/">Qubes mailing lists and forum</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not the intended way to fix this.

I doubt there's supposed to be HTML in this text snippet. If you look here, you can see the problematic line:

{{ community.text }} <a href="{{ support_link }}"> {{ community.mail }}</a>.

The problem is that I can't find support_link anywhere else. Looks like this was introduced in #153. @maiska, what did you have in mind here?

Copy link
Author

@ghost ghost Apr 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, there is probably a better way. This method works (it renders correctly), I don't know enough about jekyll to know how to do it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sorry for my long silence, I should be more flexible from now on. This here is clearly a mistake, sorry for that, this should be declared a variable which slipped the commit if I am not mistaken in the history of the file, such as {% assign team_link = lang | append: "/team/" %}
somthing like that:
{% assign support_link = lang | append: "/support/" %}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sorry for my long silence, I should be more flexible from now on. This here is clearly a mistake, sorry for that, this should be declared a variable which slipped the commit if I am not mistaken in the history of the file, such as {% assign team_link = lang | append: "/team/" %}

somthing like that:

{% assign support_link = lang | append: "/support/" %}

@maiska: Take a look at what has already been merged and please submit a new PR if warranted.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewdavidwong I see you fixed it :) Thank you

@ghost
Copy link
Author

ghost commented Apr 17, 2021

Slight improvement from before, still could use some improvement. the upperlinks section has all of its text/url pairs inside another layer (security/bug/ect), while community (after this commit) has some in the top level and some nested under mail.

@andrewdavidwong andrewdavidwong merged commit 28710cd into QubesOS:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website: broken link on "team"

2 participants