Skip to content

Conversation

@Mazzya
Copy link
Member

@Mazzya Mazzya commented Dec 25, 2024


name: Pull Request
about: Create a pull request to contribute to QubiPy
title: 'Add wallet ID validation to prevent invalid API calls'
labels: ''
assignees: ''

Description

This merge request adds input validation for wallet IDs before making API calls. The changes include:

  • A new validation function to check wallet ID format
  • Optimization of network calls by preventing invalid requests
  • Enhanced security by validating inputs before API calls

These changes help prevent unnecessary network calls.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature with breaking changes)
  • 📚 Documentation update
  • 🔨 Code refactoring
  • 🧪 Test updates

Testing

  • All tests pass
  • New tests added for changes

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • All tests pass locally

Screenshots

Additional Notes

@Mazzya Mazzya added the enhancement New feature or request label Dec 25, 2024
@Mazzya Mazzya self-assigned this Dec 25, 2024
@Mazzya Mazzya merged commit b0d9fb5 into v0.2.6-dev Dec 25, 2024
@Mazzya Mazzya deleted the feature/validate_wallet_id branch December 25, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants