Skip to content

fix: 修复scheduleBackup的interval被错误的识别为Cron表达式导致无法启动计划 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkyDynamic merged 3 commits into from
Sep 22, 2025
Merged

fix: 修复scheduleBackup的interval被错误的识别为Cron表达式导致无法启动计划 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26e7294
perf: suggest改为使用可以从缓存获取
SkyDynamic Aug 3, 2025
3aafd28
Merge branch 'QuickBackupMultiMod-Dev:1.21' into 1.21
SkyDynamic Sep 18, 2025
edb1023
fix: 修复scheduleBackup的interval被错误的识别为Cron表达式导致无法启动计划
SkyDynamic Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/main/java/io/github/skydynamic/quickbakcupmulti/QuickbakcupmultiReforged.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static void setNewDataBase(String collectionName) {

String appendFolder = (QuickbakcupmultiReforged.getModContainer().getEnvType() == ModEnvType.CLIENT) ? "/" + collectionName : "";
DatabaseManager databaseManager = new DatabaseManager(
"QuickBakcupMulti",
"QuickBackupMulti",
QuickbakcupmultiReforged.getModConfig().getStoragePath(),
UUID.nameUUIDFromBytes(collectionName.getBytes())
);
Expand Down
2 changes: 1 addition & 1 deletion common/src/main/java/io/github/skydynamic/quickbakcupmulti/event/OnLoadedWorldHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static void handler() {
Runnable scheduleBackupRunnable = new DefaultScheduleBackupRunnable();
if (scheduleBackupConfig.interval != null) {
int interval = (int) DurationUtils.parseDurationToSeconds(scheduleBackupConfig.interval);
ScheduleManager.registerSchedule("scheduleBackup", databaseBackupConfig.interval, scheduleBackupRunnable);
ScheduleManager.registerSchedule("scheduleBackup", interval, scheduleBackupRunnable);
} else if (scheduleBackupConfig.crontab != null) {
ScheduleManager.registerSchedule("scheduleBackup", scheduleBackupConfig.crontab, scheduleBackupRunnable);
}
Expand Down
4 changes: 2 additions & 2 deletions common/src/main/java/io/github/skydynamic/quickbakcupmulti/schedule/impl/ModSchedule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public boolean startSchedule() {
jobDetail = JobBuilder.newJob(this.getClass()).withIdentity(identity).build();
StdSchedulerFactory sf = new StdSchedulerFactory();

if (crontab != null && !crontab.isEmpty() && interval == null) {
if (crontab != null && !crontab.isEmpty()) {
trigger = buildTrigger(identity, CronUtils.ScheduleMode.CRONTAB, crontab);
} else if (interval != null && interval > 0 && crontab == null) {
} else if (interval != null && interval > 0) {
trigger = buildTrigger(identity, CronUtils.ScheduleMode.INTERVAL, interval);
} else {
return false;
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
org.gradle.jvmargs = -Xmx2G
org.gradle.parallel = true
# Mod properties
mod_version = 3.2.0
mod_version = 3.2.2
maven_group = io.github.skydynamic
mod_id = quickbakcupmulti_reforged
archives_name = QuickBakcupMulti-Reforged
Expand Down