Optimize API usage and 3D cube refresh lifecycle#4
Open
QuirkyRobots wants to merge 3 commits intov4from
Open
Conversation
Deploying 3data with
|
| Latest commit: |
8f6a5fb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33ca2e5e.3data.pages.dev |
| Branch Preview URL: | https://codex-analyze-and-optimize-w.3data.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isPrivacyCoinfrom the CoinGecko payload inextractCoinDataand replaced the extra fetch withupdatePrivacyCoinIndicator, removing the redundant CoinGecko round-trip (modifiesjs/api-manager.js).window.getExchangeRate()once and only update URL params, preventing duplicate network calls and extra state churn (modifiesjs/ui-controller.js).setupMusicMuteToggle()frominitializeUI(modifiesjs/ui-controller.js).createEnvironmentMap()and added adisposeCube()helper that disposes geometry, material maps, and materials when replacing the cube;refreshCube()now removes the old cube, creates a new one and disposes the old resources (modifiesjs/object-renderer.js).createCubeGeometry).Testing
node --check js/api-manager.js,node --check js/ui-controller.js, andnode --check js/object-renderer.js, all of which completed successfully.git commit(commit created successfully).Codex Task