Rename GEMINI_CLI_INTEGRATION_TEST to QWEN_CODE_INTEGRATION_TEST and refactor sandbox user handling#1966
Merged
tanzhenxin merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
- Update integration test environment variable name - Ensure sandbox container naming works correctly with new variable Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Contributor
📋 Review SummaryThis PR renames the environment variable 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Renamed the environment variable
GEMINI_CLI_INTEGRATION_TESTtoQWEN_CODE_INTEGRATION_TESTto align with the project name. Refactored sandbox container user handling to support integration tests that need access to the host's~/.qwendirectory while maintaining backward compatibility for standard test runs.Dive Deeper
This PR addresses naming consistency and improves sandbox user handling for integration tests:
Environment Variable Rename:
GEMINI_CLI_INTEGRATION_TESTtoQWEN_CODE_INTEGRATION_TESTin:integration-tests/globalSetup.ts- sets the variable for test runspackages/cli/src/utils/sandbox.ts- reads the variable to detect integration test modeSandbox User Handling Refactoring:
The previous logic had a bug where integration tests that need to access the host's
~/.qwendirectory (e.g., for--resumefunctionality) couldn't work properly. The new logic distinguishes four cases based onQWEN_CODE_INTEGRATION_TESTandSANDBOX_SET_UID_GID:truetrue~/.qwen)truefalsefalsetruefalsefalseAdditional Changes:
-sflag frombuild:sandboxnpm script inpackage.jsonReviewer Test Plan
Run the build to ensure no compilation errors:
Run integration tests to verify sandbox container creation works:
Verify that containers are named correctly with
qwen-code-integration-test-prefix during integration tests.If testing
--resumefunctionality in integration tests, ensureSANDBOX_SET_UID_GID=trueis set and verify the container can access the host's~/.qwendirectory.Testing Matrix
Linked issues / bugs