fix(tools): trim whitespace from skill name to prevent lookup failures#2027
Closed
echoVic wants to merge 5 commits intoQwenLM:mainfrom
Closed
fix(tools): trim whitespace from skill name to prevent lookup failures#2027echoVic wants to merge 5 commits intoQwenLM:mainfrom
echoVic wants to merge 5 commits intoQwenLM:mainfrom
Conversation
QwenLM#2025) - Trim skill name in validateToolParams to handle cases where model adds extra whitespace - Update params.skill with trimmed value for consistent usage throughout the tool - Add test cases for leading/trailing whitespace and Chinese skill names Fixes QwenLM#2025
echoVic
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
added 3 commits
March 1, 2026 11:43
… API errors (QwenLM#2020) - Add PDF (application/pdf) to unsupported media types in convertUnsupportedMediaToText - This prevents 'Invalid value: file' API errors when reading PDF files - PDF content in tool responses is now converted to explanatory text - Add test cases for PDF inlineData and fileData conversion Fixes QwenLM#2020
- Add 'bash' and 'sh' to ToolNamesMigration as aliases for 'run_shell_command' - Migrate legacy tool names in CoreToolScheduler._schedule() before registry lookup - Add test case verifying the migration mapping
This was referenced Mar 2, 2026
Collaborator
|
@echoVic Thanks for your contribution! This issue is caused by interleaved English/number characters and Chinese Characters, and the model has some trouble with this pattern. Pls checkout issue #1922 for more details. We prefer not to merge any hotfix patch for this issue, and we are communicating with the related team if this issue can be fixed at the model side once for all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling skills with Chinese names (or any name), the model sometimes adds extra whitespace around the skill name, causing the lookup to fail and resulting in an infinite loop.
Fixes #2025
Changes
validateToolParamsto handle cases where model adds extra whitespaceparams.skillwith trimmed value for consistent usage throughout the toolTesting
' code-review''code-review '' code-review '' '