feat(cli): improve auth dialog UX with clearer three-option layout#2030
Merged
tanzhenxin merged 5 commits intomainfrom Mar 2, 2026
Merged
feat(cli): improve auth dialog UX with clearer three-option layout#2030tanzhenxin merged 5 commits intomainfrom
tanzhenxin merged 5 commits intomainfrom
Conversation
- Replace nested API-KEY submenu with flat three-option layout - Add descriptive labels for each authentication method: - Qwen OAuth: Free, up to 1,000 requests/day - Alibaba Cloud Coding Plan: Paid, multiple model providers - API Key: Bring your own API key - Simplify region selection for Coding Plan (China vs Global) - Use DescriptiveRadioButtonSelect for better visual hierarchy - Add itemGap prop to BaseSelectionList for spacing - Update i18n strings in en.js, zh.js, and ru.js - Simplify custom API key configuration info view - Clean up unused region-specific strings Closes #2016 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Contributor
📋 Review SummaryThis PR redesigns the authentication dialog with a cleaner, more intuitive three-option layout that displays descriptive labels for each authentication method. The changes improve UX by flattening the hierarchy and providing clear information about each option's pricing, limits, and capabilities. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Update error handling to display user-friendly quota exceeded messages with links to Alibaba Cloud Coding Plan upgrade options. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
This was referenced Mar 1, 2026
- Add validation to check API key starts with "sk-sp-" for China region - Add Chinese translation for the validation error message - Only apply prefix validation when region is aliyun.com (China) This prevents users from submitting invalid API keys for the China region, providing immediate feedback with a localized error message. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
…odels Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Redesigns the authentication dialog with a cleaner, more intuitive three-option layout. Each authentication method now displays a descriptive label showing key details (free vs paid, request limits, available models), helping users quickly understand their options.
Key changes:
Dive Deeper
The previous auth dialog had a nested structure where users first selected "API-KEY" and then chose between Coding Plan (China), Coding Plan (Global/Intl), or Custom. This was confusing because:
The new design addresses these issues by:
Technical Changes
itemGapprop toBaseSelectionListandDescriptiveRadioButtonSelectfor better visual spacingregionNamefromgetCodingPlanConfigreturn value (now using translation key)AuthDialog.tsxstate management (removedselectedIndexandapiKeySubModeIndex)Reviewer Test Plan
Test auth dialog display:
npm startin a fresh project (no existing auth)Test Qwen OAuth flow:
Test Coding Plan flow:
Test API Key flow:
Test navigation:
Testing Matrix
Linked issues / bugs
🤖 Generated with Qwen Code