fix: handle symlinks during extension installation#2056
Merged
tanzhenxin merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
When installing extensions from GitHub repos containing symlinks (e.g. symlinks pointing to directories), the copy operation fails with ENOTSUP: operation not supported on socket, copyfile. Root cause: git clone without core.symlinks=true creates text files instead of real symlinks on some platforms, and fs.promises.cp cannot copy these entries properly. Fix applied at two layers: 1. git clone: add -c core.symlinks=true to preserve symlinks 2. copyExtension: add dereference:true to follow symlinks and copy actual content, with a filter to skip non-regular files 3. gemini-converter copyDirectory: resolve symlinks via realpathSync and copy target content 4. claude-converter collectResources: skip non-regular files Fixes #2050
Contributor
📋 Review SummaryThis PR addresses the 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fix
ENOTSUP: operation not supported on socket, copyfileerror when installing extensions from GitHub repos that contain symlinks (e.g. symlinks pointing to directories).Dive Deeper
When a GitHub repo contains symlinks (like
.claude/skills/ui-ux-pro-max/data→../../../src/ui-ux-pro-max/data), the extension installation fails because:git clonewithoutcore.symlinks=truemay create text files instead of real symlinks on some platformsfs.promises.cpcannot handle these entries, throwing a misleadingENOTSUPerrorThis PR applies a two-layer fix:
github.ts-c core.symlinks=trueto preserve symlinks during cloneextensionManager.tsdereference: true+ filter to follow symlinks and skip non-regular filesgemini-converter.tsrealpathSyncand copy target contentclaude-converter.tscollectResourcesReviewer Test Plan
ENOTSUPerrorsTesting Matrix
Linked issues / bugs
Fixes #2050