Skip to content

perf: optimize style hoisting and remove setting x-qwik/vnode#8366

Merged
wmertens merged 1 commit intobuild/v2from
v2-less-style-recalc
Feb 18, 2026
Merged

perf: optimize style hoisting and remove setting x-qwik/vnode#8366
wmertens merged 1 commit intobuild/v2from
v2-less-style-recalc

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Feb 17, 2026

  • wrap hoisting styles in document fragment and dont move styles inside head.
  • remove setting attribute x-qwik/vnode, the container is created only once, and vnode processing is done during container creating, so its not needed

@Varixo Varixo self-assigned this Feb 17, 2026
@Varixo Varixo requested a review from a team as a code owner February 17, 2026 15:32
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

🦋 Changeset detected

Latest commit: d36a103

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Feb 17, 2026
@Varixo Varixo linked an issue Feb 17, 2026 that may be closed by this pull request
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 17, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8366
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8366
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8366
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8366

commit: d36a103

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d36a103

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 9bcf41b into build/v2 Feb 18, 2026
21 checks passed
@wmertens wmertens deleted the v2-less-style-recalc branch February 18, 2026 13:44
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Extra style recalculation on Qwik start

2 participants

Comments