Updating zenodo file #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldgrantcsu
reviewed
Jul 20, 2022
Member
ldgrantcsu
left a comment
ldgrantcsu
left a comment
There was a problem hiding this comment.
The zenodo file looks good to me. My only question @freemansw1 is why multiple previous commits you made are also showing up in the pull request. Is this from updating your fork?
Member
Author
|
Yes, that's from merging my fork (and from us doing a squash merge earlier). We can squash merge to get rid of them or just deal with the commit history |
Member
Author
|
I should also note that updating my fork was a huge headache with the change in the folder inside of |
Member
|
Agreed.. yes that causes some unnecessary extra steps. OK looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the zenodo file to fix the bugs. I used this website: https://www.jsonschemavalidator.net/ to validate the JSON file and then used this schema description: https://zenodraft.github.io/metadata-schema-zenodo/latest/schema.json .