Steve's updates past v6.3.03 for new tagged version v.6.3.04 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grid to inner grid (by Leah Grant)
…nucleate new droplets at the minimum mean diameter.
…to improve ice crystal prediction, prevent artificial number adjustment, and permit small hydrometeor mixing ratio and number concentrations.
…perature in DeMott formula to -35C so that we do not improperly extrapolate nucleation rates to colder temperatures.
…can be either, and named them like CN1NP and CN2NP as condensation nuclei modes 1 & 2 number prognosed. Same done for the mass variables.
…nit_ifn. These are from SPICULE and MC3E field data. Also changed the CCN and GCCN naming convention in REVU files that had not been modified in previous commit.
ldgrantcsu
reviewed
Aug 31, 2023
Member
|
Hey Steve, overall looks good, I have three questions first.
|
Member
Author
|
I did not put any info on the use of CIN_MAX = -2 or -1 in the namelist
setting since I'm not sure exactly where this will go in the future. But
there is a note in the namelist doc for the user to look at "init_ifn" for
how the profile is initialized. The SPICULE and MC3E profiles are hardcoded
if chosen, such that they don't really use the CIN_MAX value. I was just
using an easy way to trigger these on or off for testing. We can refine
this in the future.
…On Thu, Aug 31, 2023 at 3:04 PM Leah Grant ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On src/io/rname.f90
<#17 (comment)>:
Is this a change in the namelist settings? Is it documented in the RAMSIN,
so CIN_MAX can be set to as low as -2 and that activates the new SPICULE or
Peter's MC3E profiles?
—
Reply to this email directly, view it on GitHub
<#17 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARRUHJEUOTFGGI6GRLYRXI3XYD36TANCNFSM6AAAAAA4EYBZ2Q>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Member
Author
|
Let's incorporate INCUS code changes later. I'll leave that up to you and
the INCUS team.
Perhaps we should add the namelist nudging code flags now.
Could you write up a short blurb I could add to the RAMSIN namelist
document about the names of the nudging code flags, what they do, and how
the values should be chosen? If you can do that, then I'll add the flags to
the code, test them out, and send you an updated pull request.
Thanks,
Steve
…On Thu, Aug 31, 2023 at 3:06 PM Leah Grant ***@***.***> wrote:
Hey Steve, overall looks good, I have three questions first.
- Did we want to incorporate the other INCUS code changes? Or at a
later time?
- We should add namelist options for the new nudging code I added
(e.g. timescale for nudging and number of grid points to nudge in each
grid) but this could be a to-do for a later time
- Question I posted with the commit on new INP profiles - it looks
like the namelist setting range was changed, just wanted to check if that
was updated in the namelist description too.
—
Reply to this email directly, view it on GitHub
<#17 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARRUHJHCY4MYYNYME45R4ILXYD4G5ANCNFSM6AAAAAA4EYBZ2Q>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
smsaleeb
force-pushed
the
main
branch
2 times, most recently
from
f0ae943 to
1203c20
Compare
Updated test simulation scripts and namelist to work correctly. Creating new version tag as v6.3.04 at this point.
Member
Author
|
Added updated sponge layer flags and documentation. I think this is ready to go. |
ldgrantcsu
approved these changes
Sep 7, 2023
Member
ldgrantcsu
left a comment
ldgrantcsu
left a comment
There was a problem hiding this comment.
OK thanks Steve for all the feedback and for going ahead and adding the nested grid namelist flags. It looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes Leah's LBC updates + all my INP and cloud nucleation updates. Also, renaming of CCN and GCCN categories. Updated documentation to make it more current. Tagged latest code as v6.3.04.