Skip to content

Adding Noob Black#332

Merged
NicEastvillage merged 2 commits intoRLBot:masterfrom
rocketeeroof:master
Dec 27, 2024
Merged

Adding Noob Black#332
NicEastvillage merged 2 commits intoRLBot:masterfrom
rocketeeroof:master

Conversation

@rocketeeroof
Copy link
Contributor

This version of Noob Black is the same one that has been modified to fit v5, only that it works for v4.

Comment on lines +38 to +39
def next_bounce(pos, vel, height, g):
def solve_quadratic(a, b, c, ans, side):
Copy link
Contributor

@NicEastvillage NicEastvillage Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could gain many performance improvements by making these nested functions into methods or global functions. Currently, then are redefined every tick.

Copy link
Contributor

@NicEastvillage NicEastvillage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only is your bot basically one file, it is also basically one function (with nested ones instead). Impressive.

Maybe your next endeavour should be learning how to structure your bot in multiple files and delete the stuff you don't use. You could also improve your code by getting rid of magic numbers.

I need you to fix your tags before I accept the PR.

fun_fact = The bot has a Roblox background.

# Tags
tags = goalie, teamplay, rumble, hoops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goalie tag is reserved for bots that ONLY play goalie. The rumble tag is for bots that use the rumble items.

@rocketeeroof
Copy link
Contributor Author

The tags have been changed.

@NicEastvillage NicEastvillage merged commit 9b29b71 into RLBot:master Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants