fix(Nexto_EZ): buffer randomness value consistency#335
Merged
NicEastvillage merged 1 commit intoRLBot:masterfrom Sep 6, 2025
Merged
fix(Nexto_EZ): buffer randomness value consistency#335NicEastvillage merged 1 commit intoRLBot:masterfrom
NicEastvillage merged 1 commit intoRLBot:masterfrom
Conversation
Updates the Nexto_EZ bot to match user expectations when the GUI slider is unmodified. * when initialized the `Nexto_EZ` class loads the shared memory buffer with a value from 0-255 where 0 represents a fully random bot and 255 is fully nexto. * when initialized the gui expects the value to be in the 0=fully-random format and displays correctly, but does not update the value until the slider is adjusted. * when the slider is adjusted it writes a 0-255 value where 255 is random and 0 is fully nexto. (Note that this is inverted from the initialization step.) * when deciding whether the tick should be random or not the `Nexto_EZ` class expects the buffer to contain a 0-255 value where 255 is fully random. (see line 50) It seems to match expectations if the user modifies the slider before playing. However if the slider is not changed, or when `SHOW_GUI` is set to False the bot's behavior will be the inverse of expectation. * update the initialization of the class and gui to set and expect the 0=fully-nexto 255=fully-random format, respectively. * add debug logging to elevate confidence the bot is behaving as expected. defaults to False/Off
Contributor
Author
|
If you'd prefer this to be resolved in a different way, or if there are concerns with the logging, I can update the pull request. |
NicEastvillage
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Nexto_EZ bot to match user expectations when the GUI slider is unmodified.
Issues
Nexto_EZclass loads the shared memory buffer with a value from 0-255 where 0 represents a fully random bot and 255 is fully nexto.Nexto_EZclass expects the buffer to contain a 0-255 value where 255 is fully random. (see line 50)It seems to match expectations if the user modifies the slider before playing. However if the slider is not changed, or when
SHOW_GUIis set to False the bot's behavior will be the inverse of expectation.Proposed fix