-
Notifications
You must be signed in to change notification settings - Fork 66
Closed
Labels
bugSomething isn't workingSomething isn't workingnext releaseThe bug is fixed and the fix will be available in the next release.The bug is fixed and the fix will be available in the next release.
Description
On RecordsFactory, within the method "getRecords", there is a check to see if the given reference formulation found in the mapping file is actually supported by the mapper. In the case of a non-supported reference formulation found, the code logs an error and leaves the execution run without returning from the method or throwing a controlled error.
// Select the Record Factory based on the reference formulation.
if (!referenceFormulationRecordFactoryMap.containsKey(referenceFormulation)) {
logger.error("Referenceformulation {} is unsupported!", referenceFormulation);
}
ReferenceFormulationRecordFactory factory = referenceFormulationRecordFactoryMap.get(referenceFormulation);
records = factory.getRecords(access, logicalSource, rmlStore);Instead what happens is a factory is tried to be retrieved and use this reference, which leads to a NullPointerExcepcion that in turn gets propagated all the way up the Executor class. This happens between lines 138 and 142 of the class RecordsFactory. I have verified this error is still present on the development branch.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingnext releaseThe bug is fixed and the fix will be available in the next release.The bug is fixed and the fix will be available in the next release.