Skip to content

Conversation

@duschu
Copy link
Contributor

@duschu duschu commented Jan 31, 2019

Added Maven Central repository and updated jsonld-java dependency in order to fix issue #18

Added Maven Central repository and updated jsonld-java dependency in order to fix issue #18
@duschu
Copy link
Contributor Author

duschu commented Jan 31, 2019

The issue #18 is related to a conflict between the Maven Central and the Jitpack repositories. The issue-related project with the groupId "com.github.jsonld-java" exist in both repositories. In fact, we want it to be fetched from the official Maven Central repository. But the groupId also follows the Jitpack naming convention, thus Jitpack tries to fetch the project from github using their own dependency resolution logic. Here, a conflict occurs and the Maven build fails.

The problem can be solved by explicitly specifying Maven Central as the first repository to use for dependency resolution in the Maven POM file. In addition, I changed the dependency groupId of the jsonld-java project according to their own documentation under https://github.com/jsonld-java/jsonld-java.

In order to build the project successfully, it might be necessary to clean the local Maven repository cache on your machine, at least the /com/github/jsonld-java directory.

@duschu duschu mentioned this pull request Jan 31, 2019
@bjdmeest
Copy link
Collaborator

bjdmeest commented Feb 4, 2019

This looks great, thanks! It'll be part of our next release, somewhere later this month :)

@bjdmeest bjdmeest merged commit 7212640 into RMLio:master Feb 27, 2019
francisco-quevedo added a commit to DiSSCo/openDS_CRUD_operator that referenced this pull request May 4, 2020
…it.com/r/pretendyourexyzzy/comments/fnd0r1/issue_with_dependencies_not_sure_what_to_do jsonld-java RMLio/rmlmapper-java#19

Include small dwc-a sample files
Ignore test in LogUtils as we don't control when logger flushes buffer to file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants