Mitigate localization security issue by disabling HTML rendering#4
Merged
Mitigate localization security issue by disabling HTML rendering#4
Conversation
Mitigate a localization security issue by disabling HTML-based translation rendering. Switched data-i18n-html usages to data-i18n-text in ControlPanel.html, removed support for data-i18n-html/innerHTML in the i18n source (sc-common.js) and updated the compiled components (sc-components.js). Updated locale files to remove embedded HTML (e.g. removed <b> tags) and added a changelog entry for v1.2.2.0. Also includes generated/packed plugin outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a security issue related to localization in the Property Inspector by removing HTML-based translation rendering and switching to plain text for help text. It also updates the changelog to document this patch.
Security and Localization Fixes:
ControlPanel.htmlto prevent potential security issues. (PluginCore/PropertyInspector/Keys/ControlPanel.html, [1] [2]Documentation Updates:
CHANGELOG.md, CHANGELOG.mdR18-R23)