Merged
Conversation
* propagate_constant ignores `unpack_fp4` instructions now * `match_find_mx_quantizable_ops` from `simplify_qdq` updated to not require non-constant scales. The scales can be literals. * transpose, reshape, and broadcast instructions propagated on scale instructions when going to `quant_dot` and `quant_conv` * `raw_data` `operator<<` updated to use `fallback_visit` to also handle non-computable types
rocmlir supports GEMM+GEMM fusion, so MIGraphX needs to support the fusion on our side. Solves #4230
This PR implements a lowering transformation that converts LRN operations into a series of pooling and arithmetic operations.
| | Default: No tuning is done for composable kernels. | ||
|
|
||
| * - | ``MIGRAPHX_REWRITE_LRN`` | ||
| | Turns on LRN-to-pooling lowering in the rewrite_pooling pass. |
Contributor
There was a problem hiding this comment.
Part of me thinks rewrite_pooling should be in code text: rewrite_pooling
I would check how the passes are written in the rest of the text and keep the same formatting.
spolifroni-amd
approved these changes
Oct 7, 2025
Contributor
spolifroni-amd
left a comment
spolifroni-amd
left a comment
There was a problem hiding this comment.
This looks OK to me. I had only one small comment and it's up to you whether you want to change this.
anisha-amd
approved these changes
Oct 7, 2025
causten
commented
Oct 8, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/rocm-rel-7.1 #4358 +/- ##
=======================================================
Coverage ? 92.26%
=======================================================
Files ? 560
Lines ? 26358
Branches ? 0
=======================================================
Hits ? 24319
Misses ? 2039
Partials ? 0
🚀 New features to boost your workflow:
|
TedThemistokleous
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
7.1 branch cut missed important fixes
Technical Details
Changelog Category