Skip to content

limit max_split_per_batch to 16#47

Merged
valarLip merged 2 commits intomainfrom
limit_max_split_per_batch
Dec 14, 2025
Merged

limit max_split_per_batch to 16#47
valarLip merged 2 commits intomainfrom
limit_max_split_per_batch

Conversation

@valarLip
Copy link
Copy Markdown
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings December 12, 2025 14:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes two main changes: (1) replaces the "topk": -1 parameter with "max_split_per_batch": 16 in the MLA attention metadata builder to properly limit batch splitting, and (2) applies code formatting improvements to the linear operations module.

  • Corrects the split_params configuration in aiter_mla.py by replacing an incorrect parameter name
  • Reformats function signatures and reorganizes imports in linear.py for better code readability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
atom/model_ops/attentions/aiter_mla.py Replaces "topk": -1 with "max_split_per_batch": 16 in the split_params dictionary passed to get_mla_metadata_v1
atom/model_ops/linear.py Code formatting improvements including import reorganization, multi-line function signatures, and whitespace cleanup; introduces a duplicate import issue

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread atom/model_ops/linear.py Outdated
@valarLip valarLip merged commit 24c79bb into main Dec 14, 2025
5 checks passed
@valarLip valarLip deleted the limit_max_split_per_batch branch December 14, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants