Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes two main changes: (1) replaces the "topk": -1 parameter with "max_split_per_batch": 16 in the MLA attention metadata builder to properly limit batch splitting, and (2) applies code formatting improvements to the linear operations module.
- Corrects the split_params configuration in
aiter_mla.pyby replacing an incorrect parameter name - Reformats function signatures and reorganizes imports in
linear.pyfor better code readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| atom/model_ops/attentions/aiter_mla.py | Replaces "topk": -1 with "max_split_per_batch": 16 in the split_params dictionary passed to get_mla_metadata_v1 |
| atom/model_ops/linear.py | Code formatting improvements including import reorganization, multi-line function signatures, and whitespace cleanup; introduces a duplicate import issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist