(ci)(recipe): Add DeepSeek-R1 FP4 TP4 validation and DS recipe for SGLang-ATOM#614
Open
zhuyuhua-v wants to merge 5 commits intomainfrom
Open
(ci)(recipe): Add DeepSeek-R1 FP4 TP4 validation and DS recipe for SGLang-ATOM#614zhuyuhua-v wants to merge 5 commits intomainfrom
zhuyuhua-v wants to merge 5 commits intomainfrom
Conversation
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
zhuyuhua-v
requested review from
ZLkanyo009,
ZhiweiYan-96,
qichu-yun,
wuhuikx and
zejunchen-zejun
qichu-yun
previously approved these changes
Apr 21, 2026
wuhuikx
previously approved these changes
Apr 22, 2026
valarLip
previously approved these changes
Apr 23, 2026
Collaborator
still wip?
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DeepSeek-R1 FP4 (MXFP4 weights) TP4 accuracy coverage to the ATOM SGLang CI/validation flows and documents how to run/benchmark/validate DeepSeek-R1 using the SGLang-ATOM backend.
Changes:
- Add DeepSeek-R1 FP4 TP4 (MXFP4 checkpoint) to PR CI accuracy matrix and to nightly/manual accuracy validation matrix.
- Align DeepSeek-R1 FP8 TP4 GSM8K accuracy threshold from
0.92to0.91across workflows and dashboard model metadata. - Add an SGLang-ATOM DeepSeek-R1 recipe covering server launch, benchmarking, profiling, and GSM8K validation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
recipes/sglang_atom/DeepSeek-R1.md |
New SGLang-ATOM DeepSeek-R1 recipe (launch, benchmark, profiling, lm-eval). |
.github/workflows/atom-sglang-test.yaml |
Updates PR CI accuracy threshold and adds DeepSeek-R1 FP4 TP4 to the matrix. |
.github/workflows/atom-sglang-accuracy-validation.yaml |
Adds manual toggle + nightly coverage for DeepSeek-R1 FP4 TP4; aligns FP8 TP4 threshold. |
.github/benchmark/sglang_models_accuracy.json |
Adds/updates dashboard metadata for the two DeepSeek-R1 TP4 accuracy entries (thresholds, baseline fields). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
zhuyuhua-v
dismissed stale reviews from wuhuikx, valarLip, and qichu-yun
via
91f30ab
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepSeek-R1-FP4 TP4coverage to SGLang-ATOM accuracy flows, including nightly/manual validation and dashboard metadata, with a0.85GSM8K thresholdDeepSeek-R1-FP8 TP4GSM8K threshold to0.91across the ATOM SGLang PR and nightly accuracy workflows to avoid data floating issues.recipes/sglang_atom/DeepSeek-R1.mdin the same style as the vLLM-ATOM recipe, covering server launch, benchmarking, accuracy validation, and profiling usage