[vllm-atom] Fix GLM-5 accuracy in vLLM plugin#669
Open
kliuae-amd wants to merge 1 commit intomainfrom
Open
Conversation
Signed-off-by: kliuae <kuanfu.liu@embeddedllm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes the accuracy drop of GLM-5 in vLLM-ATOM mode.
Technical Details
Build ragged layout in every layer.
Use
top_k_per_row_prefillfrom vLLM that handles indexing more consistently across short/long context lengths.In combination with bugfix for
cp_gather_indexer_k_quant_cachein aiter ROCm/aiter#2954, accuracy is restored to baseline.Test Plan
Accuracy test with
lm_evalModel:
zai-org/GLM-5-FP8Server command
lm_evalcommand:Test Result
Submission Checklist