Skip to content

Revert hip cooperative groups workaround #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jithunnair-amd merged 8 commits into from
Jun 29, 2021
Merged

Revert hip cooperative groups workaround #21

jithunnair-amd merged 8 commits into from
Jun 29, 2021

Conversation

@rraminen
Copy link

@rraminen rraminen commented Jun 29, 2021

-This PR contains the following:

  • Revert the workaround implemented for HIP cooperative groups.

The files normalize_kernels.cu, softmax_kernels.cu and general_kernels.cu now use HIP cooperative groups APIs.

  • The condition " CUDA_ARCH >= 700 || defined(HIP_PLATFORM_HCC)" to enable the code on CUDA and ROCm systems

CC: @jithunnair-amd

@jithunnair-amd jithunnair-amd changed the title Pr revert hip cooperative groups workaround Revert hip cooperative groups workaround Jun 29, 2021
jithunnair-amd
jithunnair-amd approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@jithunnair-amd jithunnair-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jithunnair-amd jithunnair-amd merged commit bf2979b into ROCm:master Jun 29, 2021
jithunnair-amd added a commit that referenced this pull request Jun 29, 2021
@jithunnair-amd
Revert "Merge pull request #21 from rraminen/PR_Revert_HIP_Cooperativ…
5b0fac7 
…e_Groups_Workaround"

This reverts commit bf2979b, reversing
changes made to 0cf3306.
@jithunnair-amd jithunnair-amd mentioned this pull request Jun 29, 2021
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rraminen @jithunnair-amd