Skip to content

Conversation

@valarLip
Copy link
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings October 15, 2025 16:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Namespace introduction for rope kernels and associated interface updates.

  • Wrap rope helper functions in the aiter namespace and adjust consumers.
  • Add using directive in CUDA kernel TU to pick up names from aiter.
  • Expand pybind registrations with explicit argument names.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
csrc/kernels/rope/rope_common.h Wrap rope helper functions with namespace aiter and close it before macro definitions.
csrc/kernels/rope/pos_fwd_kernels.cu Add using namespace aiter to access newly namespaced symbols.
csrc/include/rocm_ops.hpp Reformat pybind definitions and add explicit py::arg names for rope_cached_positions_2c_fwd_impl.
aiter/jit/core.py Minor docstring normalization tweak in check_args.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

valarLip and others added 2 commits October 16, 2025 10:23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@valarLip valarLip merged commit 079b748 into main Oct 17, 2025
16 of 18 checks passed
@valarLip valarLip deleted the rope_add_namespace branch October 17, 2025 12:54
eliotwang pushed a commit to eliotwang/aiter that referenced this pull request Oct 21, 2025
* add aiter namespace to rope

* update

* Update aiter/jit/core.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants