CI: parallel build Aiter whl packages for Python 3.10 and 3.12 #1204
Conversation
gyohuangxin
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Aiter release workflow to support parallel building of wheel packages for multiple Python versions (3.10 and 3.12). The workflow now uses a matrix strategy to build packages concurrently, with configurable inputs to selectively enable/disable builds for each Python version.
Key Changes:
- Introduced a matrix build strategy supporting Python 3.10 and 3.12 with version-specific Docker images
- Added workflow inputs (
build_py310,build_py312) to control which Python versions to build - Updated container naming and artifact uploads to include Python version identifiers
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| build_enabled: ${{ github.event.inputs.build_py310 == 'true' || github.event.inputs.build_py310 == true }} | ||
| - python_version: "3.12" | ||
| docker_image: "rocm/pytorch:rocm7.0.2_ubuntu24.04_py3.12_pytorch_release_2.8.0" | ||
| build_enabled: ${{ github.event.inputs.build_py312 == 'true' || github.event.inputs.build_py312 == true }} |
There was a problem hiding this comment.
The build_enabled expression will always evaluate to true for pull_request events because github.event.inputs will be null. This causes the skip logic in step 46-50 to fail. Consider defaulting to true when inputs are not present: ${{ github.event.inputs.build_py312 != 'false' && github.event.inputs.build_py312 != false }}
| build_enabled: ${{ github.event.inputs.build_py310 == 'true' || github.event.inputs.build_py310 == true }} | |
| - python_version: "3.12" | |
| docker_image: "rocm/pytorch:rocm7.0.2_ubuntu24.04_py3.12_pytorch_release_2.8.0" | |
| build_enabled: ${{ github.event.inputs.build_py312 == 'true' || github.event.inputs.build_py312 == true }} | |
| build_enabled: ${{ github.event.inputs.build_py310 != 'false' && github.event.inputs.build_py310 != false }} | |
| - python_version: "3.12" | |
| docker_image: "rocm/pytorch:rocm7.0.2_ubuntu24.04_py3.12_pytorch_release_2.8.0" | |
| build_enabled: ${{ github.event.inputs.build_py312 != 'false' && github.event.inputs.build_py312 != false }} |
.github/workflows/aiter-release.yaml
Outdated
| - name: Check if build is enabled for this Python version | ||
| if: ${{ !matrix.build_enabled }} | ||
| run: | | ||
| echo "Build for Python ${{ matrix.python_version }} is disabled. Skipping job." | ||
| exit 0 |
There was a problem hiding this comment.
[nitpick] This skip step is unnecessary. When a matrix job should be skipped, use a conditional on the entire job instead: add if: matrix.build_enabled at the job level (line 28) and remove the individual step conditionals. This is cleaner and prevents the job from running at all when disabled.
gyohuangxin
force-pushed
the
aiter_release_ci_py3.12
branch
from
10c19d8 to
b0f6a79
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.