Skip to content

Conversation

@valarLip
Copy link
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings October 23, 2025 09:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the CK library copying mechanism during build time and switches to using CK libraries directly from their source locations. The change eliminates unnecessary file system operations that were copying CK header files to a temporary directory before each build.

Key changes:

  • Removed the recopy_ck() function that was copying CK library files
  • Updated include paths to point directly to CK source directories instead of copied directories
  • Updated copyright notice format in the CK config header

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
aiter/jit/core.py Removed recopy_ck() function and its invocation; updated include paths to reference CK libraries directly from CK_3RDPARTY_DIR and CK_HELPER_DIR
3rdparty/ck_helper/ck/config.h Changed copyright notice format from lowercase "(c)" to uppercase "(C)"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@valarLip valarLip merged commit c83597b into main Oct 23, 2025
16 of 17 checks passed
@valarLip valarLip deleted the avoid_copy_ck branch October 23, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants