Skip to content

Conversation

@yzhou103
Copy link
Contributor

@yzhou103 yzhou103 commented Oct 23, 2025

by adding i8gemm codegen to generate empty config map for gfx950

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings October 23, 2025 13:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a gfx950 build error by adding i8gemm codegen functionality that generates an empty config map when no CSV configuration files are found for gfx950, falling back to creating a placeholder configuration.

Key changes:

  • Adds a new codegen.py script for gfx950 i8gemm kernel configuration generation
  • Implements fallback logic to generate empty configuration maps when gfx950-specific CSV files are absent
  • Generates C++ header files with kernel configuration structures and macros

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yzhou103 yzhou103 changed the title fix gfx950 build error by adding i8gemm codegen to generate empty con… [MI35x] fix gfx950 build error Oct 23, 2025
@valarLip valarLip merged commit b306934 into main Oct 24, 2025
18 of 19 checks passed
@valarLip valarLip deleted the fix_i8gemm_gfx950_build branch October 24, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants