Skip to content

Conversation

@yzhou103
Copy link
Contributor

@yzhou103 yzhou103 commented Oct 24, 2025

Motivation

Fix build bdist wheel error

Technical Details

q_dtype_w== dtype.fp8 limitation is not required,
kernelId >=0 and kernelId < len(kernels_list) can make sure that it only generates lookup map with ck kernels.
kernelId of asm kernels starts with len(kernels_list) + 1

Test Plan

PREBUILD_KERNELS=1 GPU_ARCHS="gfx942" python3 setup.py bdist_wheel

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings October 24, 2025 07:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a build error when creating a binary distribution wheel by removing unnecessary code and correcting documentation strings. The main issue was an unnecessary dependency on the aiter.utility.dtypes module and a filtering condition that caused build failures.

Key changes:

  • Removed unused imports and filtering logic related to q_dtype_w in the kernel generation code
  • Updated outdated description strings in argument parsers to accurately reflect their purpose

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
csrc/ck_gemm_a8w8_bpreshuffle/gen_instances.py Removed unnecessary aiter module imports and q_dtype_w filtering that caused the build error
hsa/gfx942/i8gemm/codegen.py Updated argument parser description to accurately describe i8gemm kernel generation
hsa/gfx950/i8gemm/codegen.py Updated argument parser description and added comment about missing gfx950 kernels

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@valarLip valarLip merged commit c7e3d34 into main Oct 24, 2025
18 of 19 checks passed
@valarLip valarLip deleted the fix_build_bdist_wheel_error branch October 24, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants