-
Notifications
You must be signed in to change notification settings - Fork 166
[Draft] [Preview] Support gfx1201 #1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tjtanaa
wants to merge
16
commits into
ROCm:main
Choose a base branch
from
EmbeddedLLM:support_gfx1201
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into support_gfx1201
Signed-off-by: Amir Balwel <amoooori04@gmail.com>
Signed-off-by: Amir Balwel <amoooori04@gmail.com>
…into support_gfx1201
…ion kernel Signed-off-by: Amir Balwel <amoooori04@gmail.com>
…into support_gfx1201
Contributor
Author
Contributor
Author
|
@valarLip could we get some preliminary thoughts about this? Will there be any concerns in us upstreaming the configs and tuning scripts, and fixes like this unified attention fix is acceptable or not (EmbeddedLLM@1574097)? |
Signed-off-by: Amir Balwel <amoooori04@gmail.com>
Co-authored-by: Jeff Aw <jeffaw99@hotmail.com> Signed-off-by: Amir Balwel <amoooori04@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There has been huge interest in the vLLM community in using AITER triton kernels for Radeon. The testing has shown significant performance benefits on Radeon GPU as well. vllm-project/vllm#28649 (comment)
We are working with @hongxiayang on enabling and upstreaming all the tuning configs and tuning scripts to AITER Radeon as a proper support.
The work will then be broken down into multiple PRs to upstream to AITER.
Technical Details
Phase 1 (Done)
Tasks
Understand which triton op is failing for gfx1201
Run unit tests using the community patch vllm-project/vllm#28649
Results is based on this commit f4e4188
All of the important triton kernels can run on RDNA 4:
test_gemm_a8w8.logall passed.test_gemm_a8w8_per_token_scale.logall passed.test_gemm_a8w8_block_scale.logall passed.test_batched_gemm_a8w8.logAll passed, just some OOMtest_batched_gemm_bf16.logAll passed, just OOMtest_moe.logAll passed with just 4/850 fails. Greattest_unified_attention.logAll passing with 41/823 failures (hardware config failure, has been solved in EmbeddedLLM@1574097 of our branch)test_rmsnorm.logAll pass, just very small mismatch and OOM .test_mha.logall workings for forwards one, just with some OOMPhase 2 (Enable GPU Arch on gfx1201)
Tasks:
The checklist of this phase is the list of ops to enable
Current progress:
Test Plan
Ensure we can run the unit tests.
Kernels are also tuned.
Test Result
Phase 1 (DONE): Test Results of unit tests using the community patch
All of the important triton kernels can run on RDNA 4:
test_gemm_a8w8.logall passed.test_gemm_a8w8_per_token_scale.logall passed.test_gemm_a8w8_block_scale.logall passed.test_batched_gemm_a8w8.logAll passed, just some OOMtest_batched_gemm_bf16.logAll passed, just OOMtest_moe.logAll passed with just 4/850 fails. Greattest_unified_attention.logAll passing with 41/823 failures (hardware config failure, has been solved in EmbeddedLLM@1574097 of our branch)test_rmsnorm.logAll pass, just very small mismatch and OOM .test_mha.logall workings for forwards one, just with some OOMSubmission Checklist