Skip to content

Conversation

@azaidy
Copy link
Contributor

@azaidy azaidy commented Dec 27, 2025

Reverts #1456

@azaidy azaidy requested review from a team, k50112113 and vgokhale December 27, 2025 19:54
Comment on lines +6 to +7
import triton
import aiter.ops.triton.utils._triton.arch_info as arch_info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
triton imported but unused

Suggested change
import triton
import aiter.ops.triton.utils._triton.arch_info as arch_info
import aiter.ops.triton.utils._triton.arch_info as arch_info

Comment on lines +7 to 8
import aiter.ops.triton.utils._triton.arch_info as arch_info
from aiter.ops.triton.utils.logger import AiterTritonLogger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
aiter.ops.triton.utils._triton.arch_info imported but unused

Suggested change
import aiter.ops.triton.utils._triton.arch_info as arch_info
from aiter.ops.triton.utils.logger import AiterTritonLogger
from aiter.ops.triton.utils.logger import AiterTritonLogger

Comment on lines +7 to 8
import triton.language as tl
import aiter.ops.triton.utils._triton.arch_info as arch_info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
triton.language imported but unused

Suggested change
import triton.language as tl
import aiter.ops.triton.utils._triton.arch_info as arch_info
import aiter.ops.triton.utils._triton.arch_info as arch_info

Comment on lines +9 to 10
from aiter.ops.triton.quant import _mxfp4_quant_op
from aiter.ops.triton.utils.logger import AiterTritonLogger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
aiter.ops.triton.quant._mxfp4_quant_op imported but unused

Suggested change
from aiter.ops.triton.quant import _mxfp4_quant_op
from aiter.ops.triton.utils.logger import AiterTritonLogger
from aiter.ops.triton.utils.logger import AiterTritonLogger

Comment on lines +7 to 8
import triton.language as tl
import aiter.ops.triton.utils._triton.arch_info as arch_info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
triton.language imported but unused

Suggested change
import triton.language as tl
import aiter.ops.triton.utils._triton.arch_info as arch_info
import aiter.ops.triton.utils._triton.arch_info as arch_info

Comment on lines 10 to 16
from aiter.ops.triton._triton_kernels.gemm_afp4wfp4 import (
_gemm_afp4wfp4_kernel,
_gemm_afp4wfp4_kernel_preshuffle_scales,
_gemm_afp4wfp4_preshuffle_kernel,
_gemm_afp4wfp4_reduce_kernel,
_get_config,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
aiter.ops.triton._triton_kernels.gemm_afp4wfp4._gemm_afp4wfp4_kernel_preshuffle_scales imported but unused

Suggested change
from aiter.ops.triton._triton_kernels.gemm_afp4wfp4 import (
_gemm_afp4wfp4_kernel,
_gemm_afp4wfp4_kernel_preshuffle_scales,
_gemm_afp4wfp4_preshuffle_kernel,
_gemm_afp4wfp4_reduce_kernel,
_get_config,
)
from aiter.ops.triton._triton_kernels.gemm_afp4wfp4 import (
_gemm_afp4wfp4_kernel,
_gemm_afp4wfp4_preshuffle_kernel,
_gemm_afp4wfp4_reduce_kernel,
_get_config,
)

Comment on lines +6 to +7
import triton
import triton.language as tl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
triton imported but unused

Suggested change
import triton
import triton.language as tl
import triton.language as tl

Comment on lines +7 to 8
import triton.language as tl
from aiter.ops.triton.utils.logger import AiterTritonLogger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [ruff] <F401> reported by reviewdog 🐶
triton.language imported but unused

Suggested change
import triton.language as tl
from aiter.ops.triton.utils.logger import AiterTritonLogger
from aiter.ops.triton.utils.logger import AiterTritonLogger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants