Skip to content

Conversation

@alexdutu
Copy link
Contributor

@alexdutu alexdutu commented May 6, 2025

image

@alexdutu alexdutu requested review from rahulbatra85 and vgokhale May 6, 2025 00:11
@rahulbatra85
Copy link
Contributor

@alexdutu Can you please address the issues reported by the black/linter CI?
It's a required CI, so will need to fix those before this PR can be merged. Thanks!

Copy link
Contributor

@rahulbatra85 rahulbatra85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code. Thanks!

@alexdutu
Copy link
Contributor Author

@rahulbatra85 I removed all the comments you've mentioned and some extra ones, and added the fixes from the black tool.

@rahulbatra85 rahulbatra85 changed the title Adding Lean + Paged Attention, for decode [TRITON]: Adding Lean + Paged Attention, for decode Jul 9, 2025
@rahulbatra85 rahulbatra85 self-requested a review July 18, 2025 18:10
@rahulbatra85 rahulbatra85 merged commit 69ba678 into ROCm:main Jul 18, 2025
10 checks passed
cagrikymk pushed a commit that referenced this pull request Jul 30, 2025
* Adding Lean + Paged Attention, for decode

* Removing unused vars

* Adding a benchmark script for lean+paged attention

* Replacing torch_to_tl_dtype with torch_to_triton_dtype

* Comments removed and black fixes

* More comments removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants