Skip to content

Conversation

@TennyWang1223
Copy link
Contributor

replace static_cast as safe function
add template param: vectorialize size, ngpus, dtype
add dispatch logic

Signed-off-by: root <root@hjbog-srdc-24.amd.com>
@valarLip
Copy link
Collaborator

ck_tile::type_convert<float>(tgt_key) * inverted_kscale);

let's transfer to ck_tile type_convert

Signed-off-by: root <root@hjbog-srdc-24.amd.com>
@valarLip valarLip self-assigned this Jul 2, 2025
Copy link
Collaborator

@valarLip valarLip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valarLip valarLip merged commit d032efa into main Jul 2, 2025
11 of 13 checks passed
@valarLip valarLip deleted the update_allreduce branch July 2, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants