Skip to content

Conversation

@rahulbatra85
Copy link
Contributor

No description provided.

@rahulbatra85 rahulbatra85 force-pushed the ds_batra_merged branch 2 times, most recently from c72515a to 5c0e50a Compare June 23, 2025 23:19
@k50112113
Copy link
Contributor

So it seems that here is a file called aiter/ops/triton/gemm_afp4wfp4_pre_quant_atomic.py for DS but it's not here, are we not merging this one here?

@rahulbatra85
Copy link
Contributor Author

So it seems that here is a file called aiter/ops/triton/gemm_afp4wfp4_pre_quant_atomic.py for DS but it's not here, are we not merging this one here?

@k50112113 There is no test case for that. I am working on adding that and will push once it's done

Copy link
Contributor

@k50112113 k50112113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I think there are still some reviewdog failing, would be great if you can fix that, thx

@rahulbatra85 rahulbatra85 requested a review from k50112113 June 24, 2025 15:30
@rahulbatra85 rahulbatra85 merged commit 0e9bbff into main Jun 24, 2025
13 checks passed
@rahulbatra85 rahulbatra85 deleted the ds_batra_merged branch June 24, 2025 22:51
@k50112113 k50112113 restored the ds_batra_merged branch June 25, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants