(Triton] RoPE dev #606
Merged
(Triton] RoPE dev #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in test except 2d cases
rahulbatra85
approved these changes
Jul 8, 2025
fsx950223
pushed a commit
that referenced
this pull request
Jul 11, 2025
* rename test_rope_triton.py to test_rope.py * enable all API in bench, apply generate_rope_inputs to all test func in test except 2d cases * (rebase) re-order * (rebase) re-order * new _rope_fwd_kernel_neox kernel * merge _rope_fwd_kernel_gptj and _rope_fwd_kernel_neox into _rope_fwd_kernel * (rebase) get rid of nope kernel * (rebase) merge all _thd kernels into one kernel * change test_rope_fwd to test_rope_fwd_sbhd * (rebase) merge all cached/positions/offsets kernels into one kernel * resolve failing test cases for cached kernels * clean * clean * (rebase) merge cached_2c kernels * add nope into kernels * rebase clean up * add rope bwd for sbhd * add rope bwd for thd * add rope bwd for cached thd and two_input cached thd * merge gqa into two_input wrapper and add rope bwd for two_input gqa * update bench rope and clean up * clean up * add backward hooks * black reformatting
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* rename test_rope_triton.py to test_rope.py * enable all API in bench, apply generate_rope_inputs to all test func in test except 2d cases * (rebase) re-order * (rebase) re-order * new _rope_fwd_kernel_neox kernel * merge _rope_fwd_kernel_gptj and _rope_fwd_kernel_neox into _rope_fwd_kernel * (rebase) get rid of nope kernel * (rebase) merge all _thd kernels into one kernel * change test_rope_fwd to test_rope_fwd_sbhd * (rebase) merge all cached/positions/offsets kernels into one kernel * resolve failing test cases for cached kernels * clean * clean * (rebase) merge cached_2c kernels * add nope into kernels * rebase clean up * add rope bwd for sbhd * add rope bwd for thd * add rope bwd for cached thd and two_input cached thd * merge gqa into two_input wrapper and add rope bwd for two_input gqa * update bench rope and clean up * clean up * add backward hooks * black reformatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Note, the "_gqa" API will be deprecated and will be merged to "_2c" API.
TODO: more optimization, 2D RoPE dev