-
Notifications
You must be signed in to change notification settings - Fork 171
[TRITON]: Moe tuning mi350 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ped pids, rather than the EM which contains the empty tiles
… moe-tuning-mi350
Contributor
|
@Chi-Chu319 Please address black CI issues |
rahulbatra85
reviewed
Jul 8, 2025
rahulbatra85
reviewed
Jul 8, 2025
rahulbatra85
reviewed
Jul 8, 2025
gelu and silu fused
… moe-tuning-mi350
rahulbatra85
approved these changes
Jul 10, 2025
fsx950223
pushed a commit
that referenced
this pull request
Jul 11, 2025
* Updated benchmark script
* Fixed config parsing and mi350 config
* format
* Correct the xcd_remapping to use num_tokens_post_padded for the remapped pids, rather than the EM which contains the empty tiles
* fix
* New remapping for all
* fixed tests and moe remapping
* Linter
* chunked remap jit
* Fixed comments
* fix remap on fp4 and gelu moe, and remove TODOs from the persistent versions
* print time
* num_pid_m calculated based on tokens post padded in gelu, silu and fp4 moe versions
* fix pid grid
* MI350 medium M config tuned
* even_k
* silu fused moe even_k
* mi350 small tuning
* black linting
* remove outdated TODO in persistent
* reverse black linting for json files
* fix segmem fault from persistent by turning pointers to tl.int64
* fix segmem fault from persistent by turning pointers to tl.int64
gelu and silu fused
* int64
* Black linter
* Evem k refactor
* num_stage=2
---------
Co-authored-by: Juuso Korhonen <40278371+juuso-oskari@users.noreply.github.com>
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Updated benchmark script
* Fixed config parsing and mi350 config
* format
* Correct the xcd_remapping to use num_tokens_post_padded for the remapped pids, rather than the EM which contains the empty tiles
* fix
* New remapping for all
* fixed tests and moe remapping
* Linter
* chunked remap jit
* Fixed comments
* fix remap on fp4 and gelu moe, and remove TODOs from the persistent versions
* print time
* num_pid_m calculated based on tokens post padded in gelu, silu and fp4 moe versions
* fix pid grid
* MI350 medium M config tuned
* even_k
* silu fused moe even_k
* mi350 small tuning
* black linting
* remove outdated TODO in persistent
* reverse black linting for json files
* fix segmem fault from persistent by turning pointers to tl.int64
* fix segmem fault from persistent by turning pointers to tl.int64
gelu and silu fused
* int64
* Black linter
* Evem k refactor
* num_stage=2
---------
Co-authored-by: Juuso Korhonen <40278371+juuso-oskari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: @Chi-Chu319 @juuso-oskari
WARNING: Don't merge this yet. It fails testing small shapes with our num_stage=3 change. Investigation on going. ReproducerWe change the num_stage to 2. We will investigate this outside scope of this pr. If its compiler related we will raise attention from the compiler ppl.
Fixed xcd remapping: Previously we used GRID_MN = EM // BLOCK_SIZE_M * num_pid_n for the xcd_remap(pid, GRID_MN,NUM_XCD=8). This results in the last XCD receiving all the dummy tokens (as EM=num_tokens_post_padded + dummy tokens) which have no work and have early return -> the last XCD is idling while other XCDs still have work. Fixed the GRID_MN to be calculated as GRID_MN = num_tokens_post_padded // BLOCK_SIZE_M * num_pid_n.
Perf comparison to main
main:
moe-tuning-mi350: