Update dependencies and add backup for unknown hw #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the get_dtype_fp8 helper to safely handle unknown hardware IDs by providing a fallback data type instead of raising a KeyError.
- Use
dict.getwith an inline fallback forfp8whenget_gfx()isn’t indefaultDtypes - Default unknown hardware’s FP8 dtype to
torch.uint8
Comments suppressed due to low confidence (1)
aiter/utility/dtypes.py:14
- Consider adding a unit test to cover the fallback path when get_gfx() returns an unknown key, ensuring get_dtype_fp8() correctly returns torch.uint8.
return defaultDtypes.get(get_gfx(), {"fp8": torch.uint8})["fp8"]
valarLip
requested changes
Jul 8, 2025
Collaborator
|
looks like CI have some issue... |
Contributor
Author
|
can someone re-trigger the CI? |
valarLip
approved these changes
Jul 13, 2025
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Update dependencies and add backup for unknown hw * use a variable for f8 fallback dtype * rename as requested --------- Co-authored-by: valarLip <103567126+valarLip@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.