-
Notifications
You must be signed in to change notification settings - Fork 167
[TRITON] Tune fp4xfp4 GEMM #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_model.py * Why? The idea is to have a master script that benchmarks the full set of associated kernels when given a model name. It's a little cleaner to place all kernel benchmarking scripts in /kernels and have the bench_model script call them. * How? See `bench_model.py`. Pytests are in bench_tests/
…emm_a8w8 benchmarking.
…d add --model arg
…ROCm/aiter into willz/benchmarking-improvements
azaidy
approved these changes
Jul 18, 2025
Contributor
azaidy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor
Author
|
Note: This kernel was tuned on the rocm/triton compiler - the upstream Triton compiler yields fairly poor performance. |
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Finish tuning afp4wfp4 GEMM - increase ~2x * Improve performance on standard model (e.g Llama) shapes * Add new shape tune * Optimizing performance of default config for standard model shapes * Tune performance on N=1280,K=8192 w/compiler flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few config changes to speed up the FP4xFP4 GEMM.