Pa fix2

[fsx950223]

The PR may fix pa compile bug #637 . Can't verify since lack of details.

[tjtanaa]

Will it be possible to also address the compilation warning message in this PR:

hipcc -fPIC -DUSE_ROCM -DENABLE_FP8 -O3 -std=c++17 -DLEGACY_HIPBLAS_DIRECT -DUSE_PROF_API=1 -D_HIP_PLATFORM_HCC=1 -DHIP_PLATFORM_AMD=1 -UHIP_NO_HALF_CONVERSIONS_ -U_HIP_NO_HALF_OPERATORS_ -mllvm --amdgpu-kernarg-preload-count=16 -Wno-unused-result -Wno-switch-bool -Wno-vla-cxx-
extension -Wno-undefined-func-template -fgpu-flush-denormals-to-zero -fno-offload-uniform-block -mllvm -enable-post-misched=0 -mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false --offload-arch=gfx942 -I/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include -c p
a_b218c05023abc4cd4f3fce7059bf4982.cpp -o pa_b218c05023abc4cd4f3fce7059bf4982.o                                                                                                                                                                                                                   
In file included from pa_b218c05023abc4cd4f3fce7059bf4982.cpp:1:                                                                                                                                                                                                                                  
In file included from /root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/pa.cuh:26:                                                                                                                                                                                                   
In file included from /root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/quant_utils.cuh:19:                                                                                                                                                                                          
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/vec_convert.h:66:1: warning: non-void function does not return a value [-Wreturn-type]                                                                                                                                             
   66 | }                                                                                                                                                                                                                                                                                         
      | ^                                                                                                                                                                                                                                                                                         
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/vec_convert.h:75:1: warning: non-void function does not return a value [-Wreturn-type]                                                                                                                                             
   75 | }                                                                                                                                                                                                                                                                                         
      | ^                                                                                                                                                                                                                                                                                         
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/vec_convert.h:84:1: warning: non-void function does not return a value [-Wreturn-type]                                                                                                                                             
   84 | }                                                                                                                                                                                                                                                                                         
      | ^                                                                                                                                                                                                                                                                                         
In file included from pa_b218c05023abc4cd4f3fce7059bf4982.cpp:1:                                                                                                                                                                                                                                  
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/pa.cuh:48:9: warning: 'DIVIDE_ROUND_UP' macro redefined [-Wmacro-redefined]                                                                                                                                                        
   48 | #define DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b))                                                                                                                                                                                                                                     
      |         ^                                                                                                                                                                                                                                                                                 
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/pa_common.cuh:26:9: note: previous definition is here                                                                                                                                                                              
   26 | #define DIVIDE_ROUND_UP(a, b) (((a) + (b)-1) / (b))                                                                                                                                                                                                                                       
      |         ^                                                                                                                                                                                                                                                                                 
4 warnings generated when compiling for gfx942.                                                                                                                                                                                                                                                   
In file included from pa_b218c05023abc4cd4f3fce7059bf4982.cpp:1:                                                                                                                                                                                                                                  
In file included from /root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/pa.cuh:26:                                                                                                                                                                                                   
In file included from /root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/quant_utils.cuh:19:
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/vec_convert.h:66:1: warning: non-void function does not return a value [-Wreturn-type]
   66 | }
      | ^
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/vec_convert.h:75:1: warning: non-void function does not return a value [-Wreturn-type]
   75 | }
      | ^
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/vec_convert.h:84:1: warning: non-void function does not return a value [-Wreturn-type]
   84 | }
      | ^
In file included from pa_b218c05023abc4cd4f3fce7059bf4982.cpp:1:
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/pa.cuh:48:9: warning: 'DIVIDE_ROUND_UP' macro redefined [-Wmacro-redefined]
   48 | #define DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b))
      |         ^
/root/.aiter/build/pa_b218c05023abc4cd4f3fce7059bf4982/include/pa_common.cuh:26:9: note: previous definition is here

[tjtanaa]

This fix works. Thank you for the quick fix. 🚀

[valarLip]

lgtm