Gemm a8w8 bpreshuffle api fix #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes API inconsistencies in the GEMM A8W8 bpreshuffle operation by standardizing type annotations and updating the configuration lookup logic. The changes focus on improving type consistency and modifying the fallback behavior for unsupported configurations.
- Standardizes type annotations from generic
Tensortotorch.Tensorand adds return type annotation - Updates configuration caching to support multiple tuned files simultaneously
- Removes fallback to ASM implementation and adds explicit assertions for supported data types
Comments suppressed due to low confidence (1)
aiter/ops/gemm_op_a8w8.py:36
- Parameter name 'Out' uses inconsistent capitalization. It should be 'out' to match the original naming convention and align with the variable 'Y' used in the function body.
Out: torch.Tensor,
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* add check before gemm_a8w8_bpreshuffle_ck * disable gemm_a8w8_ASM in gemm_a8w8_bpreshuffle api * fix get_CKGEMM_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.