fmoe_codegen_asm #690
fmoe_codegen_asm #690
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds command-line argument support to the MoE test script and removes a Chinese comment from the quantization test. The changes make the testing framework more flexible by allowing users to specify custom parameters via command line instead of using hardcoded values.
- Adds command-line arguments for dtype, token count, intermediate dimension, and hidden dimension
- Updates all test loops to use command-line arguments when provided, falling back to default hardcoded values
- Removes Chinese comment from quantization test configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| op_tests/test_quant.py | Removes Chinese comment from commented configuration line |
| op_tests/test_moe.py | Adds command-line argument parsing and updates test loops to use dynamic parameters |
Comments suppressed due to low confidence (2)
op_tests/test_moe.py:347
- The argument name '--token' is ambiguous. Consider renaming to '--token-count' or '--num-tokens' to be more descriptive.
"--token",
|
@amd-ruitang3 @junhaha666 FYI, this PR causes accuracy issues in sgl-project/sglang#6299 (comment) (accuracy of 0.0) Checking out to the previous commit cf29be3, everything is fine. Is this a known issue in this PR? Is there a test missing? My workload is DeepSeek R1 with TP=8. |
|
this PR modified args of fmoe with persistent mode. we will revert the commit and debug. |
|
@amd-ruitang3 thank you, do you confirm it is not just an issue on my end then? edit - false alarm, my issue stems from elsewhere in aiter. Still investigating. |
* update tests * update test * update * update_4
No description provided.