fix prebuild file path #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes prebuild file path issues by adjusting package configuration and path resolution logic. The changes address path discovery problems when the package structure differs between development and installed environments.
- Removes "csrc" from the packages list in setup.py
- Adds dynamic path resolution logic to locate the correct AITER_CORE_DIR
- Inserts the meta directory into sys.path for proper module discovery
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Removes "csrc" from the packages list to fix package structure |
| csrc/cpp_itfs/utils.py | Adds conditional logic to dynamically resolve AITER_CORE_DIR path |
| aiter/jit/core.py | Inserts AITER_META_DIR into sys.path for module discovery |
Contributor
|
Hi, sixie~ AITER_CORE_DIR and AITER_META_DIR are coupled. Can you help check? |
amd-ruitang3
approved these changes
Jul 23, 2025
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* fix prebuild file path * fix path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.