asm_fmoe_codegen #702
Merged
asm_fmoe_codegen #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces code generation for ASM FMOE (Fused Mixture of Experts) kernel configurations by adding CSV configuration files and Python codegen scripts. The changes support various data types (fp16, bf16), quantization schemes (Int8, Fp8, blockscale), and activation functions (gelu, silu) for the gfx942 GPU architecture.
- Addition of 19 CSV configuration files containing kernel specifications for different FMOE variants
- Python code generator script to convert CSV configurations into C++ header file with kernel metadata
- Updates to function signatures to support activation parameter passing
- Integration with the build system to generate ASM FMOE configurations
Reviewed Changes
Copilot reviewed 24 out of 417 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hsa/gfx942/fmoe/*.csv | Configuration files defining kernel parameters for various FMOE data type and activation combinations |
| hsa/gfx942/fmoe/codegen.py | Python script that generates C++ header file from CSV configuration data |
| csrc/include/moe_op.h | Updated function signatures to include activation parameter and improve formatting |
| aiter/ops/moe_op.py | Added activation parameter to fmoe function signature |
| aiter/jit/optCompilerConfig.json | Updated build configuration to include FMOE codegen in blob generation |
| aiter/fused_moe_bf16_asm.py | Added activation parameter to fmoe function call |
valarLip
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.