fix bug in splitK select #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a critical bug in the splitK selection logic for GEMM operations. The main issue was using XOR operator (^) instead of left bit shift (<<) when calculating splitK values from log2_k_split parameter.
- Fixes incorrect bitwise XOR operation that was producing wrong splitK values
- Simplifies conditional logic in kernel selection heuristics
- Corrects log2 calculation implementation and dictionary storage format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| op_tests/test_gemm_a4w4.py | Uncomments log2_k_split parameter to enable testing of the fixed functionality |
| csrc/py_itfs_cu/asm_gemm_a4w4.cu | Fixes splitK calculation bug, simplifies selection logic, and corrects log2 computation |
valarLip
approved these changes
Jul 24, 2025
valarLip
approved these changes
Jul 24, 2025
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: zufayu <zufayu@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.