-
Notifications
You must be signed in to change notification settings - Fork 167
[TRITON]: Add fused GEMMs to optimize FF block #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulbatra85
reviewed
Aug 1, 2025
rahulbatra85
requested changes
Aug 1, 2025
Contributor
rahulbatra85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add logging for the new op
rahulbatra85
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fused GEMM + activation + gating options to reduce memory movement overhead in a FF block.
Changes:
activationstring parameter support forgemm_a16w16to fuse an activation function with the GEMM.gemm_a16w16_gating.pywhich uses the first half of the (M, N) output along the N dimension as the gating activations and the second half as the layer activations. Produces a tensor of shape (M, N//2). This also includes anactivationparameter for the gating activation.Write a fully-fused E2E FF kernel.Will go into next PR.Benchmarks on 350x:

Post-tuning:

Benchmarks on 300x:

Multikernel-ff is where we're at right now (e.g launching two Aiter Triton GEMMs).