Skip to content

Conversation

@842974287
Copy link
Contributor

Type of alibi_enabled should be bool and logits_soft_cap_enabled is missing.

@valarLip valarLip requested a review from fsx950223 August 5, 2025 06:52
@842974287
Copy link
Contributor Author

@fsx950223 thanks for taking a look! Updated to use str_to_bool. Also wondering if you could also help take a look at my other PRs when you have time. Very much appreciated!

#779
#771
#770

@valarLip valarLip merged commit 6720f0f into ROCm:main Aug 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants