Skip to content

Conversation

@valarLip
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings August 11, 2025 06:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues in the expert parallelism (EP) test by correcting variable scoping and tensor dimension calculations. The changes address a bug where local_E was calculated after being used and fixes dimension calculations to use the correct local expert count.

  • Moves local_E calculation before its usage to fix variable scoping
  • Updates tensor shape calculations to use local_E instead of E for correct local dimensions
  • Removes performance test parameters to use defaults

@junhaha666 junhaha666 merged commit 28918c0 into main Aug 11, 2025
13 of 14 checks passed
@junhaha666 junhaha666 deleted the ep_test_fix branch August 11, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants