[AOMP] Shellcheck fixes

bin/build-deb-aomp.sh

@@ -1,4 +1,4 @@
-#/bin/bash
+#!/bin/bash
 #
 #  build-deb-aomp.sh:  Using debhelper and alien, build the aomp debian and rpm packages
 #                      This script is tested on amd64 and ppc64le linux architectures. 
@@ -10,22 +10,22 @@
 #
 
 # --- Start standard header to set AOMP environment variables ----
-realpath=`realpath $0`
-thisdir=`dirname $realpath`
-. $thisdir/aomp_common_vars
+realpath=$(realpath "$0")
+thisdir=$(dirname "$realpath")
+. "$thisdir/aomp_common_vars"
 # --- end standard header ----
 
 . /etc/lsb-release
-RELSTRING=`echo $DISTRIB_ID$DISTRIB_RELEASE | tr -d "."`
-echo RELSTRING=$RELSTRING
+RELSTRING=$(echo $DISTRIB_ID$DISTRIB_RELEASE | tr -d ".")
+echo "RELSTRING=$RELSTRING"
 
 if [ "$1" == aomp-hip-libraries ]; then
   pkgname=aomp-hip-libraries
 else
   pkgname=aomp
 fi
 
-echo Building $pkgname package
+echo "Building $pkgname package"
 
 dirname="aomp_${AOMP_VERSION_STRING}"
 sourcedir="/usr/lib/$dirname"
@@ -35,7 +35,7 @@ DEBFULLNAME="Greg Rodgers"
 DEBEMAIL="Gregory.Rodgers@amd.com"
 export DEBFULLNAME DEBEMAIL
 
-DEBARCH=`uname -m`
+DEBARCH=$(uname -m)
 if [ "$DEBARCH" == "x86_64" ] ; then 
    DEBARCH="amd64"
 fi
@@ -46,115 +46,123 @@ if [ "$DEBARCH" == "aarch64" ] ; then
    DEBARCH="arm64"
 fi
 
-tmpdir=/tmp/$USER/build-deb
-builddir=$tmpdir/$pkgname
-if [ -d $builddir ] ; then 
+tmpdir="/tmp/$USER/build-deb"
+builddir="$tmpdir/$pkgname"
+if [ -d "$builddir" ] ; then
    echo 
    echo "--- CLEANUP LAST BUILD: rm -rf $builddir"
-   sudo rm -rf $builddir
+   sudo rm -rf "$builddir"
 fi
 
 debdir=$PWD/debian
-froot=$builddir/$pkgname-$AOMP_VERSION
-mkdir -p $froot$installdir
-mkdir -p $froot/usr/share/doc/$dirname
+froot="$builddir/$pkgname-$AOMP_VERSION"
+mkdir -p "$froot$installdir"
+mkdir -p "$froot/usr/share/doc/$dirname"
 echo 
 echo "--- PREPARING fake root directory $froot"
-sed -i -e "s|//|/|g" $BUILD_DIR/build/rocmlibs/installed_files.txt
+sed -i -e "s|//|/|g" "$BUILD_DIR/build/rocmlibs/installed_files.txt"
 if [ "$pkgname" == "aomp-hip-libraries" ]; then
-  cat $BUILD_DIR/build/rocmlibs/installed_files.txt | xargs -I {} cp -d --parents {} $froot
+  xargs -I {} cp -d --parents {} "$froot" < "$BUILD_DIR/build/rocmlibs/installed_files.txt"
 else
   # Create a temporary file to exclude math libraries if present
-  if [ -f $BUILD_DIR/build/rocmlibs/installed_files.txt ]; then
+  if [ -f "$BUILD_DIR/build/rocmlibs/installed_files.txt" ]; then
     tmpfile=/tmp/tmp_installed_files.txt
-    rm -f $tmpfile
-    cp $BUILD_DIR/build/rocmlibs/installed_files.txt $tmpfile
-    sed -i -e "s/\/usr\/lib\/$dirname\///g" $tmpfile
-    echo "rocblas" >> $tmpfile
-    echo "lib/rocblas" >> $tmpfile
+    rm -f "$tmpfile"
+    cp "$BUILD_DIR/build/rocmlibs/installed_files.txt" "$tmpfile"
+    sed -i -e "s/\/usr\/lib\/$dirname\///g" "$tmpfile"
+    echo "rocblas" >> "$tmpfile"
+    echo "lib/rocblas" >> "$tmpfile"
   fi
-  rsync -a $sourcedir"/" --exclude ".*" --exclude "rocblas" --exclude "rocsparse" --exclude "rocprim" --exclude "hipblas" --exclude "rocsolver" --exclude "hipblas-common" --exclude-from=$tmpfile $froot$installdir
+  rsync -a "$sourcedir/" --exclude ".*" --exclude "rocblas" --exclude "rocsparse" --exclude "rocprim" --exclude "hipblas" --exclude "rocsolver" --exclude "hipblas-common" --exclude-from="$tmpfile" "$froot$installdir"
 fi
 
 if [ "$pkgname" == "aomp-hip-libraries" ]; then
-  mkdir -p $froot/usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}
-  cp $debdir/copyright $froot/usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}/.
-  cp $debdir/LICENSE.TXT $froot/usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}/.
+  mkdir -p "$froot/usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}"
+  cp "$debdir/copyright" "$froot/usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}/."
+  cp "$debdir/LICENSE.TXT" "$froot/usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}/."
 else
-  cp $debdir/copyright $froot/usr/share/doc/$dirname/.
-  cp $debdir/LICENSE.TXT $froot/usr/share/doc/$dirname/.
+  cp "$debdir/copyright" "$froot/usr/share/doc/$dirname/."
+  cp "$debdir/LICENSE.TXT" "$froot/usr/share/doc/$dirname/."
 fi
 
-cp -rp $debdir $froot/debian
+cp -rp "$debdir" "$froot/debian"
 if [ "$DEBARCH" != "amd64" ] ; then 
-  echo    sed -i -e"s/amd64/$DEBARCH/" $froot/debian/control
-  sed -i -e"s/amd64/$DEBARCH/" $froot/debian/control
+  echo "sed -i -e\"s/amd64/$DEBARCH/\" $froot/debian/control"
+  sed -i -e"s/amd64/$DEBARCH/" "$froot/debian/control"
 fi
 
 if [ "$pkgname" == "aomp-hip-libraries" ]; then
-  echo sed -i -e"s/Source: aomp/Source: $pkgname/" $froot/debian/control
-  sed -i -e"s/Source: aomp/Source: $pkgname/" $froot/debian/control
-  echo sed -i -e"s/Package: aomp/Package: $pkgname/" $froot/debian/control
-  sed -i -e"s/Package: aomp/Package: $pkgname/" $froot/debian/control
+  echo "sed -i -e\"s/Source: aomp/Source: $pkgname/\" $froot/debian/control"
+  sed -i -e"s/Source: aomp/Source: $pkgname/" "$froot/debian/control"
+  echo "sed -i -e\"s/Package: aomp/Package: $pkgname/\" $froot/debian/control"
+  sed -i -e"s/Package: aomp/Package: $pkgname/" "$froot/debian/control"
 fi
 
 # Make the install and links file version specific
 if [ "$pkgname" == "aomp-hip-libraries" ]; then
-  echo "usr/lib/$dirname" > $froot/debian/$pkgname.install
-  echo "usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}" >> $froot/debian/$pkgname.install
+  {
+    echo "usr/lib/$dirname"
+    echo "usr/share/doc/${pkgname}_${AOMP_VERSION_STRING}"
+  } > "$froot/debian/$pkgname.install"
 else
-  echo "usr/lib/$dirname usr/lib/aomp" > $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/aompExtractRegion /usr/bin/aompExtractRegion" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/cloc.sh /usr/bin/cloc.sh" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/mymcpu  /usr/bin/mymcpu" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/mygpu  /usr/bin/mygpu" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/aompversion /usr/bin/aompversion" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/aompcc /usr/bin/aompcc" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname/bin/gpurun /usr/bin/gpurun" >> $froot/debian/$pkgname.links
-  echo "usr/lib/$dirname" > $froot/debian/$pkgname.install
-  echo "usr/share/doc/$dirname" >> $froot/debian/$pkgname.install
+  {
+    echo "usr/lib/$dirname usr/lib/aomp"
+    echo "usr/lib/$dirname/bin/aompExtractRegion /usr/bin/aompExtractRegion"
+    echo "usr/lib/$dirname/bin/cloc.sh /usr/bin/cloc.sh"
+    echo "usr/lib/$dirname/bin/mymcpu  /usr/bin/mymcpu"
+    echo "usr/lib/$dirname/bin/mygpu  /usr/bin/mygpu"
+    echo "usr/lib/$dirname/bin/aompversion /usr/bin/aompversion"
+    echo "usr/lib/$dirname/bin/aompcc /usr/bin/aompcc"
+    echo "usr/lib/$dirname/bin/gpurun /usr/bin/gpurun"
+  } > "$froot/debian/$pkgname.links"
+  {
+    echo "usr/lib/$dirname"
+    echo "usr/share/doc/$dirname"
+  } > "$froot/debian/$pkgname.install"
 fi
 
 echo 
 
 echo "--- BUILDING SOURCE TARBALL $builddir/${pkgname}_$AOMP_VERSION.orig.tar.gz "
 echo "    FROM FAKEROOT: $froot "
-cd $builddir
-tar -czf $builddir/${pkgname}_$AOMP_VERSION.orig.tar.gz ${pkgname}-$AOMP_VERSION
+cd "$builddir" || exit
+tar -czf "$builddir/${pkgname}_$AOMP_VERSION.orig.tar.gz" "${pkgname}-$AOMP_VERSION"
 echo "    DONE BUILDING TARBALL"
 
 echo 
 echo "--- RUNNING dch TO MANANGE CHANGELOG "
-cd  $froot
+cd "$froot" || exit
 # Skip changelog editor for docker release builds.
-echo dch -v ${AOMP_VERSION_STRING} -e --package $pkgname
+echo "dch -v ${AOMP_VERSION_STRING} -e --package $pkgname"
 if [ "$DOCKER" == "1" ]; then
-  dch -v ${AOMP_VERSION_STRING} --package $pkgname ""
+  dch -v "${AOMP_VERSION_STRING}" --package "$pkgname" ""
 else
-  dch -v ${AOMP_VERSION_STRING} --package $pkgname
+  dch -v "${AOMP_VERSION_STRING}" --package "$pkgname"
 fi
 # Backup the debian changelog to git repo, be sure to commit this 
-cp -p $froot/debian/changelog $debdir/.
+cp -p "$froot/debian/changelog" "$debdir/."
 
-debuildargs="-us -uc -rsudo --lintian-opts -X files,changelog-file,fields"
+declare -a debuildargs
+
+debuildargs=(-us -uc -rsudo --lintian-opts -X "files,changelog-file,fields")
 echo 
-echo "--- BUILDING DEB: debuild $debuildargs "
-debuild $debuildargs 
+echo "--- BUILDING DEB: debuild" "${debuildargs[@]}"
+debuild "${debuildargs[@]}"
 dbrc=$?
 echo "    DONE BUILDING DEB WITH RC: $dbrc"
 if [ "$dbrc" != "0" ] ; then 
    echo "ERROR during debuild"
-   exit $dbrc
+   exit "$dbrc"
 fi
 # Backup debhelper log to git repo , be sure to commit this
-cp -p $froot/debian/${pkgname}.debhelper.log $debdir/.
+cp -p "$froot/debian/${pkgname}.debhelper.log" "$debdir/."
 
-mkdir -p $tmpdir/debs
-if [ -f $tmpdir/debs/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb ] ; then 
-  rm -f $tmpdir/debs/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb 
+mkdir -p "$tmpdir/debs"
+if [ -f "$tmpdir/debs/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb" ] ; then
+  rm -f "$tmpdir/debs/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb"
 fi
 # Insert the os release name
-cp -p $builddir/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb $tmpdir/debs/${pkgname}_${RELSTRING}_${AOMP_VERSION_STRING}_$DEBARCH.deb
+cp -p "$builddir/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb" "$tmpdir/debs/${pkgname}_${RELSTRING}_${AOMP_VERSION_STRING}_$DEBARCH.deb"
 echo 
 echo "DONE Debian package is in $tmpdir/debs/${pkgname}_${AOMP_VERSION_STRING}_$DEBARCH.deb"
 echo